Skip to content

improved prime_check in math modules #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 11, 2022
Merged

improved prime_check in math modules #6044

merged 6 commits into from
Jul 11, 2022

Conversation

Lakshmikanth2001
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 11, 2022
@Lakshmikanth2001 Lakshmikanth2001 requested a review from poyea March 17, 2022 06:56
poyea
poyea reviewed Apr 3, 2022
View reviewed changes
maths/prime_check.py Outdated
@@ -32,12 +32,15 @@ def prime_check(number: int) -> bool:
if 1 < number < 4:
# 2 and 3 are primes
return True
elif number < 2 or not number % 2:
# Negatives, 0, 1 and all even numbers are not primes
elif number < 2 or not number % 2 or number % 3 == 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif number < 2 or not number % 2 or number % 3 == 0:
elif number < 2 or number % 2 == 0 or number % 3 == 0:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about numbers like 25, 35, 65 etc ?

Copy link
Contributor Author

@Lakshmikanth2001 Lakshmikanth2001 Apr 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those numbers are divisible by 5 6k-1 we are starting our loop with 5

@ghost ghost added the tests are failing Do not merge until tests pass label Apr 4, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jul 10, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 10, 2022
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Jul 10, 2022
@Lakshmikanth2001
Copy link
Contributor Author

please review my changes and give your valuable feed back

@poyea
Copy link
Member

poyea commented Jul 11, 2022

Related #6228

@poyea poyea self-assigned this Jul 11, 2022
poyea
poyea approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

I'd approve this because this uses one of the properties - I can't tell if it's intuitive or not though

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 11, 2022
@poyea poyea merged commit dcc3876 into TheAlgorithms:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imtheshubh imtheshubh imtheshubh left review comments

@emelia811 emelia811 emelia811 left review comments

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lakshmikanth2001 @poyea @imtheshubh @emelia811